-
Notifications
You must be signed in to change notification settings - Fork 61
Upgrade boringSSl #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade boringSSl #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhushangitfull It looks like you've committed Python virtual environment files to the repository. Could you please remove the .venv
directory so we can proceed with the review?
Also, could you please list the steps you took for this upgrade?
Sure, here are the steps. The update process consists of the following key steps: 1. Cleanup: 2. Fetch Latest Revision: 3. Copy BoringSSL: 4. Bump Revision: |
Let's do this in two PRs. (1) PR that lands a script for rolling a BoringSSL update. In practice, we probably need to have me or someone else trusted run (2), in an ideal world we can run it in Github Actions. It's simply impossible to even attempt to review this PR, and we absolutely can't a BoringSSL update without being able to prove that the files from BoringSSL have not been tampered with. Nothing personal, but I think everyone wants to be certain the files are copied over correctly :D |
No description provided.